Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relax] Support TupleWrapper for Relax Expr #17773

Closed
wants to merge 6 commits into from
Closed

[Relax] Support TupleWrapper for Relax Expr #17773

wants to merge 6 commits into from

Conversation

tlopex
Copy link
Contributor

@tlopex tlopex commented Mar 23, 2025

This PR supports TupleWrapper for Relax Expr.

Hzfengsy
Hzfengsy requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@Hzfengsy Hzfengsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's necessary, as:

  • it is only a helper function but not the data structure for core IR
  • the current relax tuple has already support __len__ and __getitem__

@tlopex
Copy link
Contributor Author

tlopex commented Mar 26, 2025

Thanks. I'll close this PR @Hzfengsy

@tlopex tlopex closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hzfengsy Hzfengsy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlopex @Hzfengsy