Skip to content

Commit 5eefeb7

Browse files
committed
✨ react-codemirror used
1 parent 66bfb7f commit 5eefeb7

File tree

4 files changed

+44
-13
lines changed

4 files changed

+44
-13
lines changed

Diff for: package-lock.json

+33
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
"codemirror": "^5.48.0",
88
"react": "^16.8.6",
99
"react-bootstrap": "^1.0.0-beta.9",
10+
"react-codemirror": "^1.0.0",
1011
"react-codemirror2": "^6.0.0",
1112
"react-dom": "^16.8.6",
1213
"react-router-dom": "^5.0.1",

Diff for: src/components/JS.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React, { Component } from 'react'
22
import 'codemirror/lib/codemirror.css';
33
import '../App.css'
4-
import {Controlled as CodeMirror} from 'react-codemirror2'
4+
import CodeMirror from 'react-codemirror'
55
import 'codemirror/mode/javascript/javascript'
66
import 'codemirror/theme/dracula.css'
77
import Hello from './Hello'
@@ -19,7 +19,7 @@ export default class XML extends Component {
1919

2020
updateCode = (newCode) => {
2121
this.setState({
22-
code: newCode,
22+
code: newCode,
2323
});
2424
}
2525

@@ -42,9 +42,7 @@ export default class XML extends Component {
4242
ref={this.code}
4343
value={this.state.code}
4444
options={options}
45-
onBeforeChange={(editor, data, code) => {
46-
this.setState({code});
47-
}}
45+
onChange={this.updateCode}
4846
/>
4947
<div className="btn btn-primary p-2 my-3 toggler" onClick={this.handleSubmit}>Toggle Code Display</div>
5048
{this.state.viewOpToggle &&

Diff for: src/components/XML.js

+7-8
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React, { Component } from 'react'
22
import 'codemirror/lib/codemirror.css';
33
import '../App.css'
4-
import {Controlled as CodeMirror} from 'react-codemirror2'
4+
import CodeMirror from 'react-codemirror'
55
import 'codemirror/mode/xml/xml.js'
66
import 'codemirror/theme/dracula.css'
77
import Hello from './Hello'
@@ -20,6 +20,7 @@ export default class XML extends Component {
2020
updateCode = (newCode) => {
2121
this.setState({
2222
code: newCode,
23+
// viewOpToggle: true
2324
});
2425
}
2526

@@ -39,13 +40,11 @@ export default class XML extends Component {
3940
return (
4041
<div>
4142
<CodeMirror
42-
ref={this.code}
43-
value={this.state.code}
44-
options={options}
45-
onBeforeChange={(editor, data, code) => {
46-
this.setState({code});
47-
}}
48-
/>
43+
value={this.state.code}
44+
options={options}
45+
onChange={this.updateCode}
46+
/>
47+
4948
<div className="btn btn-primary p-2 my-3 toggler" onClick={this.handleSubmit}>Toggle Code Display</div>
5049
{this.state.viewOpToggle &&
5150
<Hello code={this.state.code} />

0 commit comments

Comments
 (0)