Allow NetworkManager and systemd-networkd #7961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is unusual to run both NetworkManager and systemd-networkd simultaneiously and doing so can cause startup problems, there is nothing inherently wrong with doing so: the services are not incompatible and some people run both, each managing different interfaces. The Armbian build framework enables one or the other but not both. Therefore, if both are enabled at first login, it is probably because the user has manually modified the image. In this case, trust that the user knows what they are doing and don't disable one of them.
github-actions
bot
added
size/small
igorpecovnik
added
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 28df43d introduced a provision to ensure that NetworkManager and systemd-networkd are not both enabled. This was done in consideration of reports on various forums of problems when both are enabled and frequent conclusion that the root cause of the problem was having them both enabled and the solution was, therefore, to disable one of them.
Investigating this further, I have reached the conclusion that enabling both is unusual but that they are not fundamentally incompatible. Issues that arise when they are both enabled are generally the result of misconfiguration. There can be problems, for example, when both try to manage the same interface. But there are people who intentionally and successfully enable both.
Further, Armbian build should not produce an image in which both are enabled: the build is intended to enable one or the other but not both. Given this, if both are enabled, it is probably due to manual modification of the image, and probably best not to interfere with such intentional modification.
Therefore, this change removes the code from the armbian-firstlogin script that disables systemd-networkd if both it and NetworkManager are enabled.
Description
Change the armbian-firstlogin script so that it does not disable systemd-networkd if both systemd-networkd and NetworkManager are enabled.
How Has This Been Tested?
I built a new image for one of my systems and successfully completed the armbian-firstlogin script.
Checklist:
Please delete options that are not relevant.