Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NetworkManager and systemd-networkd #7961

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

ig3
Copy link

@ig3 ig3 commented Mar 16, 2025

Commit 28df43d introduced a provision to ensure that NetworkManager and systemd-networkd are not both enabled. This was done in consideration of reports on various forums of problems when both are enabled and frequent conclusion that the root cause of the problem was having them both enabled and the solution was, therefore, to disable one of them.

Investigating this further, I have reached the conclusion that enabling both is unusual but that they are not fundamentally incompatible. Issues that arise when they are both enabled are generally the result of misconfiguration. There can be problems, for example, when both try to manage the same interface. But there are people who intentionally and successfully enable both.

Further, Armbian build should not produce an image in which both are enabled: the build is intended to enable one or the other but not both. Given this, if both are enabled, it is probably due to manual modification of the image, and probably best not to interfere with such intentional modification.

Therefore, this change removes the code from the armbian-firstlogin script that disables systemd-networkd if both it and NetworkManager are enabled.

Description

Change the armbian-firstlogin script so that it does not disable systemd-networkd if both systemd-networkd and NetworkManager are enabled.

How Has This Been Tested?

I built a new image for one of my systems and successfully completed the armbian-firstlogin script.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

While it is unusual to run both NetworkManager and systemd-networkd
simultaneiously and doing so can cause startup problems, there is
nothing inherently wrong with doing so: the services are not
incompatible and some people run both, each managing different
interfaces.

The Armbian build framework enables one or the other but not both.
Therefore, if both are enabled at first login, it is probably because
the user has manually modified the image. In this case, trust that the
user knows what they are doing and don't disable one of them.
@ig3 ig3 requested a review from a team as a code owner March 16, 2025 21:03
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review BSP Board Support Packages labels Mar 16, 2025
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release labels Mar 18, 2025
@igorpecovnik igorpecovnik merged commit 288e521 into armbian:main Mar 18, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
05 Milestone: Second quarter release BSP Board Support Packages Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants