Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented facebook login auth feature #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

siddaiahm
Copy link

-user can login through facebook account

    -user can login through facebook account
@siddaiahm siddaiahm force-pushed the facebook-feature branch 2 times, most recently from 405a962 to cb42413 Compare May 23, 2020 10:06
-changed from builderbook.org to heroko link
-deleted lock.json file
@tima101 tima101 requested a review from delgermurun May 23, 2020 16:48
@tima101
Copy link
Member

tima101 commented May 23, 2020

@delgermurun @klyburke I wonder if we can have a new folder inside builderbook and/or saas repositories, with custom features like FB Login. What do you think?


Alternatively, we can reject merging new features to this repo since we will not maintain them.

@klyburke
Copy link
Member

@siddaiahm thanks for the contribution!

@tima101 I would go with a separate folder containing this code, note that it is an example from a contributor and not being actively maintained by us.

@tima101
Copy link
Member

tima101 commented May 29, 2020

@siddaiahm Thank you for your contribution.

I haven't run your code but it looks good.

I created a new folder at the root of the repo: examples. You are welcome to contribute minimal working example to that folder.

The reason to put it in separate folder is because we will review but not maintain content of example folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants