Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new lineComments extension for CodeMirror #2549

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

VasylMarchuk
Copy link
Collaborator

@VasylMarchuk VasylMarchuk commented Jan 17, 2025

Related to #1231

Brief

This adds a new lineComments extension for CodeMirror, for showing and adding line comments.

Details

TBD

Checklist

  • I've thoroughly self-reviewed my changes
  • I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
  • I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

@VasylMarchuk VasylMarchuk added the enhancement New feature or request label Jan 17, 2025
@VasylMarchuk VasylMarchuk self-assigned this Jan 17, 2025
Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jan 17, 2025

Test Results

  1 files  ±0    1 suites  ±0   6m 24s ⏱️ - 1m 50s
609 tests +2  566 ✅ ±0  42 💤 +1  0 ❌ ±0  1 🔥 +1 
624 runs  +2  580 ✅  - 1  42 💤 +1  1 ❌ +1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit aa4bf41. ± Comparison against base commit de0a48c.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
567 1 566 42
View the full list of 1 ❄️ flaky tests
Chrome 132.0 Integration | Component | code-mirror &gt; Options &gt; filename: it doesn't break the editor when passed

Flake rate in main: 64.00% (Passed 18 times, Failed 32 times)

Stack Traces | 5.08s run time
Test took longer than 5000ms; test timed out.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from 9259f7e to ad61d6e Compare January 18, 2025 06:51
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from ad61d6e to 68f2ece Compare January 18, 2025 07:05
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from 68f2ece to 2ad3508 Compare January 18, 2025 07:22
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from 2ad3508 to faf747c Compare January 18, 2025 07:28
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from faf747c to 2bc3aad Compare January 18, 2025 07:37
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from 6b779b6 to 1f3bf3b Compare January 18, 2025 17:33
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from 1f3bf3b to e363460 Compare January 18, 2025 17:43
Copy link

codecov bot commented Jan 18, 2025

Bundle Report

Changes will increase total bundle size by 8.25kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 36.11MB 8.25kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/chunk.*.js 8 bytes 403.1kB 0.0%
assets/chunk.*.js -1 bytes 234.06kB -0.0%
assets/chunk.*.js 6.84kB 2.44MB 0.28%
assets/chunk.*.js 232 bytes 299.45kB 0.08%
assets/chunk.*.js 13 bytes 160.43kB 0.01%
assets/chunk.*.js 5 bytes 107.91kB 0.0%
assets/chunk.*.js 85 bytes 30.8kB 0.28%
assets/chunk.*.js 1 bytes 22.89kB 0.0%
assets/chunk.*.js 1.06kB 63.51kB 1.69%
assets/chunk.*.js -1 bytes 53.02kB -0.0%
assets/chunk.*.js 1 bytes 12.04kB 0.01%

Files in assets/chunk.*.js:

  • ./utils/code-mirror-line-comments-widget.ts → Total Size: 3.16kB

  • ./utils/code-mirror-line-comments.ts → Total Size: 2.29kB

  • ./utils/code-mirror-line-comments-expanded-plugin.ts → Total Size: 1.68kB

  • ./utils/code-mirror-line-comments-gutter.ts → Total Size: 3.23kB

Files in assets/chunk.*.js:

  • ./controllers/demo/code-mirror.ts → Total Size: 27.87kB

  • ./templates/demo/code-mirror.hbs → Total Size: 48.7kB

  • ./routes/demo/code-mirror.ts → Total Size: 1.4kB

@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from ba09d0c to b5c0cc0 Compare January 24, 2025 12:36
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from b5c0cc0 to 6d2539f Compare January 25, 2025 12:47
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from b0ae9bc to 774b7bc Compare January 26, 2025 18:41
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from 774b7bc to 3be4793 Compare January 26, 2025 20:13
@VasylMarchuk VasylMarchuk force-pushed the code-mirror/line-comments branch from 3be4793 to 50f8c19 Compare February 2, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant