Don't show Continue/Back if the concept has been completed #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis change adds a conditional rendering check to the Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Page as Concept Page
participant Renderer as Component Renderer
User->>Page: Load concept page
Page->>Renderer: Check `hasFinished` state
alt hasFinished is false
Renderer-->>Page: Render ContinueOrStepBack component
else hasFinished is true
Renderer-->>Page: Do NOT render ContinueOrStepBack component
end
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Bundle ReportChanges will increase total bundle size by 56 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
Test Results 1 files ±0 1 suites ±0 6m 54s ⏱️ - 1m 22s For more details on these errors, see this check. Results for commit ee57189. ± Comparison against base commit eb9258d. ♻️ This comment has been updated with latest results. |
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
|
@VasylMarchuk let's add some kind of test for this? Ideally one that replicates the actual user-reported bug, and not just one that checks whether the continue button is rendered or not. |
|
Good to merge in the meantime |
rohitpaulk
approved these changes
Mar 17, 2025
VasylMarchuk
force-pushed
the
fix-del-backspace-on-concept
branch
from
69b613a to
ee57189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2727
Brief
After completing the concept, Continue/Back buttons remain visible, and continue responding to Enter/Backspace key presses, stealing them from the Feedback component.
Details
This hides Continue/Back buttons if the concept has been completed.
Checklist
[percy]in the message to trigger)Summary by CodeRabbit