[정기적 문제 풀이 추가 PR] 2022.04.12 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeisneverodd
approved these changes
Apr 13, 2022
| // a 이전 모든 달의 일 수를 더한다 | ||
| for(let i = 0, len = a - 1; i < len; i++) { | ||
| totalDays += daysOfMonth[i]; | ||
| } |
There was a problem hiding this comment.
60-64 라인을 const totalDays = daysOfMonth.slice(0, a-1).reduce((acc, curr) => acc + curr, 4)
와 같이 명령형이 아닌 선언형으로 해보시는 것도 좋을 것이라 생각합니다!
There was a problem hiding this comment.
다음에 참고해서 멋진 코드 짜보겠습니다 :D
There was a problem hiding this comment.
아닙니다 제 코드는 엉망인걸요 ㅠㅠ 이미 멋진 코드를 짜고 계십니다 👍
| if(s.length === 4 || s.length === 6) { | ||
| for(let i = 0, len = s.length; i < len; i++) { | ||
| // 숫자로만 구성돼있는지 확인 | ||
| if(!Number.isInteger(parseInt(s[i], 10))) return false; |
There was a problem hiding this comment.
29번 조건분이 isNaN 함수로 대체 될 수 있을 것으로 생각됩니다!
https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/isNaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 19문제