[22.04.28] 4문제 풀이추가, 1문제 주석수정(오타수정) #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment의 경우 주석의 오타(정답번호) 수정했습니다.
yongchanson
changed the title
codeisneverodd
approved these changes
Apr 28, 2022
level-1/자연수-뒤집어-배열로-만들기.js
Outdated
Comment on lines
62
to
63
| let slice = string.substr(i, 1) * 1; | ||
| answer.push(slice); |
There was a problem hiding this comment.
🌱 웬만하면 반영해주세요. 🌱
substr이 deprecated 된 것 은 아니지만 권장되지 않는 것 같습니다! slice 메서드를 사용해보시는 것은 어떨까요?
참고링크
There was a problem hiding this comment.
slice 사용한 풀이로 수정했습니다.
level-1/평균-구하기.js
Outdated
Comment on lines
36
to
39
| let sum = 0; | ||
| for (var i = 0; i < arr.length; i++) { | ||
| sum += arr[i]; | ||
| } |
There was a problem hiding this comment.
🌱 반영해도 좋고 넘어가도 좋아요. 🌱
reduce 메서드를 사용해보시는 것은 어떨까요?
Suggested change
| let sum = 0; | |
| for (var i = 0; i < arr.length; i++) { | |
| sum += arr[i]; | |
| } | |
| const sum = arr.reduce((acc,curr)=>acc+curr,0) |
There was a problem hiding this comment.
경현님 추천대로 수정하면 채린님 풀이와 너무 겹쳐서
삭제하고 좋은 방법 생기면 추가하도록 하겠습니다.
level-1/평균-구하기.js
Outdated
| for (var i = 0; i < arr.length; i++) { | ||
| sum += arr[i]; | ||
| } | ||
| return sum / i; |
There was a problem hiding this comment.
🌱 웬만하면 반영해주세요. 🌱
var의 호이스팅 덕분에 잘 작동하는 것 같지만, 권장되지 않습니다!
Suggested change
| return sum / i; | |
| return sum / arr.length; |
There was a problem hiding this comment.
호이스팅 이용하는게 제 의도였는데
권장되지 않는 사항이라면 빼겠습니다!
참고로 let으로 변경하면 정상작동 안합니다.
|
제가 파일을 삭제해서 문제가 생긴 것 같습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.