solution 구명보트 #77
Merged
solution 구명보트 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* solution: level 2 / 하노이 탑 풀이 추가 * solution: 모음사전 * solution 체육복 * solution 모의고사 * solution 위장 * solution 튜플 * 브랜치 흐름 정리 (codeisneverodd#71) * docs: 커밋 컨벤션 수정 및 contributor 추가 * Automatic Update README.md * fix: 오타 수정 * docs: 커밋 컨벤션 변경 및 리드미 디자인 수정 * docs: 풀이 완료시점 수정 * Automatic Update README.md * docs: PR 템플릿 추가 Co-authored-by: github-actions <github-actions@github.com> * fix: base url 핫픽스 (codeisneverodd#74) * docs: 커밋 컨벤션 수정 및 contributor 추가 * Automatic Update README.md * fix: 오타 수정 * docs: 커밋 컨벤션 변경 및 리드미 디자인 수정 * docs: 풀이 완료시점 수정 * Automatic Update README.md * docs: PR 템플릿 추가 * fix: 링크 base url 수정 (codeisneverodd#73) * Automatic Update README.md Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: chaerin-dev <chaerin.dev@gmail.com> Co-authored-by: github-actions <github-actions@github.com>
codeisneverodd
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
@iHoHyeon 님 기여 감사합니다!! 말씀해주신 것 처럼 shift 연산을 사용하지 않도록 구현 하신 것이 인상적이네요 😄
주석도 잘 달아주셨고, 변수명이나 함수 풀이 모두 깔끔하네요!
PR도 올바르게 기여해주셨습니다! PR 방법이 README의 가장 하단에 있어 아마 찾으시지 못하셨을 수도 있을 것 같아요! 해당 부분이 있음을 잘 인식할 수 있도록 목차를 생성하는 방안을 고려하겠습니다
추가적으로 수정할만한 부분이 보이지 않아 Merge 하도록 하겠습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
level2 - 구명보트 풀이 추가입니다.
+ PR 컨벤션을 딱히 찾지 못했는데 앞으로도 이런식의 PR으로 기여해도 되는 걸까요?