-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github-actions): add "3.13-dev" to Python tests (#1145) #1170
Conversation
Looks like there are currently incompatibilities with |
looks like they've got it resolved. but rebasing doesn't seem to work still |
Apparently it was fixed, but the release is still pending. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1170 +/- ##
==========================================
+ Coverage 97.33% 97.56% +0.22%
==========================================
Files 42 55 +13
Lines 2104 2502 +398
==========================================
+ Hits 2048 2441 +393
- Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-help in Python 3.13
Now it turns out that Python 3.13 modifies the behaviour of There is also a single failing test caused by the removal of |
…irrors-prettier`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit hesitant about whether we should use version 3.13 or below. However, since this is not a critical test, I think we should be fine.
I'll keep it open for a few days. cc @woile @noirbizarre |
Description
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
GitHub Actions will run tests for Python 3.13 (dev).
Steps to Test This Pull Request
Additional context
closes #1145