Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong license specifier in pyproject.toml #1368

Closed
kien-truong opened this issue Mar 5, 2025 · 2 comments · Fixed by #1373
Closed

Wrong license specifier in pyproject.toml #1368

kien-truong opened this issue Mar 5, 2025 · 2 comments · Fixed by #1373

Comments

@kien-truong
Copy link

license = { text = "LICENSE" }

It should be

license = { text = "MIT LICENSE" }

or if you want to read from the LICENSE file

license = { file = "LICENSE" }

This bug is causing the PyPI package from version 4.2.0 onward to have the wrong LICENSE metadata

https://pypi.org/project/commitizen/4.2.0/

@Lee-W
Copy link
Member

Lee-W commented Mar 20, 2025

ah.., right. should be the second one. Thanks for reminding us!

@kien-truong
Copy link
Author

kien-truong commented Mar 20, 2025

In that case, you should add the License to the trove classifier too

classifiers = [
...
"License :: OSI Approved :: MIT License"
...
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants