Add Unicode Support #615
Closed
Add Unicode Support #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit can be removed once `fix/ci` is merged into `master`.
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
Codecov ReportBase: 97.92% // Head: 97.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 35 35
Lines 1252 1253 +1
=======================================
+ Hits 1226 1227 +1
Misses 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
If I'm not mistaken, some of the changes are from #605. If that's the case, I'll review it after that one is merged and rebased to this. I browsed through this PR. I think we should be able to merge it soon as well :) |
|
Hi @adam-grant-hendry , we've merged #605 . feel free to rebase this one when you have time. thanks! |
Specify `shell` as `bash` in `Run tests and linters` step. Fixes: Issue commitizen-tools#604
`argcomplete` does not support Git Bash on Windows out of the box. For details, see https://kislyuk.github.io/argcomplete/#git-bash-support.
`py -m` was added to command in `test_argcomplete_activation` during experimentation and was forgotten to be removed.
Since Poetry 1.2.0 dependency groups are introduced, and `--dev` becomes deprecated, and instead `--with dev` has to be provided.
The current default setting for `tag_format` is `None`. This is not a problem for the `bump` command, since the `normalize_tag` function defaults to `$version` when no `tag_format` is passed. However it is a problem for the `changelog` command, which seems to explicitly demand a `tag_format` in order to run a rev-range lookup. This creates issues like commitizen-tools#622. Either a sane default needs to be set for `tag_format` or the restriction in `changelog` has to be uplifted. In this commit the latter has been chosen. A test is also implemented to check that `changelog` will always compute a rev range with the default tag format. Fixes commitizen-tools#622
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
Switch `#!/bin/sh` to `#!/usr/bin/env sh` so scripts work on Windows as well as Linux and MacOS.
- Change shebang from `#!/bin/sh` to `#!/usr/bin/env sh` - Set `$PREFIX` depending on OS
`argcomplete` does not support Git Bash on Windows out of the box. For details, see https://kislyuk.github.io/argcomplete/#git-bash-support.
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
Specify `shell` as `bash` in `Run tests and linters` step. Fixes: Issue commitizen-tools#604
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unicode support by allowing configurable encodings to be specified (defaults to
utf-8).Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testFixes: Issue #516