Migrate Analyzer- and Analyzer-Tests-Infra-refactoring to main branch. #13112
+3,194
−3,543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the refactoring, adjusted for .NET 10, which results from the .NET 9 REL PR.
Note: There are not any fixes in here (as there are not in the .NET 9 Rel PR), since I wanted to separate the actual fixes from the restructuring.
The restructuring seems like a lot, but it's really an absolute low risk.
The reasons are:
That was one of the reasons, I took the risk to move the pure folder restructuring to this PR, because it is NOT affecting the runtime in any way, and secondly, it's then only the test infra and where the original Analyzers life, which changed.
A note to the NuGet updates:
Same story, it's ONLY affecting the tests. But we need to do a better job in the future, because we're waiting too long to bring the supporting test packages along. Note, that I know, that in some cases breaking changes in those Test-support NuGets make it necessary that the test code needs to change. But, well, the longer we wait...you get my drift.
Microsoft Reviewers: Open in CodeFlow