fix: asar handling of package.json

[codebytere]

Description of Change

Fixes an issue where packaged apps could sometimes fail to find the correct package.json in asar directories.

Tested with:

npx create-electron-app@6.0.4 my-commonjs-app
cd my-commonjs-app
npm run package
echo "asfjhlasf;asklfas" > package.json
./out/commonjs-app-darwin-arm64/commonjs-app.app/Contents/MacOS/commonjs-app

To ensure that it finds the package.json in app.asar as expected.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where packaged apps could sometimes fail to find the correct package.json in asar directories.

[MarshallOfSound]

Can we do this without copyFileOut, that seems excessive. I also don't think this works correctly. This is going to copy out the file at checkPath but what it would need copied out is the nearest package.json.

I think we need to actually re-implement getNearestParentPackageJSON in JS here and just have it be ASAR aware. i.e. traverse up the path tree until we leave the ASAR, then we hand it back off to native land

[MarshallOfSound]

Same here, copyFileOut isn't copying the file we need, in fact it may be a directory not a file. We should re-implement here