Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure to have a11y text to screen readers #1829

Closed
ShubhamOulkar opened this issue Mar 9, 2025 · 3 comments · Fixed by #1839
Closed

Ensure to have a11y text to screen readers #1829

ShubhamOulkar opened this issue Mar 9, 2025 · 3 comments · Fixed by #1839
Labels
a11y / accessibility Issues concerning accessibility help wanted

Comments

@ShubhamOulkar
Copy link
Member

ShubhamOulkar commented Mar 9, 2025 •
edited
Loading

Following HTML element need a11y text

 <a id="top" href="#" aria-hidden="true">
   <svg xmlns="http://www.w3.org/2000/svg" width="10" height="6" fill="none" viewBox="0 0 
     1155 1000"><path fill="currentColor" d="m577.344 0 577.346 1000H0L577.344 0Z"></path>
   </svg>
  </a>

<section id="logo">
   <a href="/" class="express">Express</a>
 </section>

Actually elements are in tabbing order and does not have accessible text for screen readers.

Success criteria

WCAG 2.4.4, WCAG 4.1.2

How to fix?

Add aria-label="scroll to top" and role="button" attributes on anchor link.
Add title="Go to Expressjs home" on logo.
@ShubhamOulkar ShubhamOulkar changed the title Ensure scroll to top have a11y text to screen readers Ensure scroll to top btn have a11y text to screen readers Mar 9, 2025
@bjohansebas bjohansebas added a11y / accessibility Issues concerning accessibility help wanted labels Mar 10, 2025
@ShubhamOulkar ShubhamOulkar changed the title Ensure scroll to top btn have a11y text to screen readers Ensure to have a11y text to screen readers Mar 13, 2025
@ShubhamOulkar
Copy link
Member Author

Hey @bjohansebas we have logos in images/brand folder. I think we should use them in header.

@carlosstenzel
Copy link
Contributor

If you can make the proposed adjustments, you can open a PR for review. Thank you for the analysis.

@bjohansebas
Copy link
Member

Yep, that's something I've wanted to do before. PRs are welcome.

This was referenced Mar 22, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y / accessibility Issues concerning accessibility help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add express logo ShubhamOulkar/expressjs.com
3 participants
@carlosstenzel @ShubhamOulkar @bjohansebas