Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eprh] Move to compiler directory #32615

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[eprh] Move to compiler directory #32615

wants to merge 1 commit into from

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 14, 2025

Moves the plugin into the compiler directory.

  • Remove eslint-plugin-react-hooks from bundles.js
  • Remove eslint-plugin-react-hooks from ReactVersions.js
  • Remove jest.config.js
  • Remove babel.config-react-compiler.js
  • Replace babel.config.js with copy from eslint-plugin-react-compiler
  • Add tsup.config.ts to eslint-plugin-react-hooks
  • Add eslint-plugin-react-hooks to compiler release scripts

Stack created with Sapling. Best reviewed with ReviewStack.

@react-sizebot
Copy link

react-sizebot commented Mar 17, 2025

Comparing: 2089052...5644e81

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 608.06 kB 608.06 kB = 107.88 kB 107.88 kB
facebook-www/ReactDOM-prod.classic.js = 653.67 kB 653.67 kB = 115.18 kB 115.18 kB
facebook-www/ReactDOM-prod.modern.js = 643.95 kB 643.95 kB = 113.59 kB 113.59 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.76 kB 0.00 kB Deleted 295.92 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.18 kB 0.00 kB Deleted 295.00 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.76 kB 0.00 kB Deleted 295.92 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.18 kB 0.00 kB Deleted 295.00 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB

Generated by 🚫 dangerJS against 5644e81

Moves the plugin into the compiler directory.

- Remove eslint-plugin-react-hooks from bundles.js
- Remove eslint-plugin-react-hooks from ReactVersions.js
- Remove jest.config.js
- Remove babel.config-react-compiler.js
- Replace babel.config.js with copy from eslint-plugin-react-compiler
- Add tsup.config.ts to eslint-plugin-react-hooks
- Add eslint-plugin-react-hooks to compiler release scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants