Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eprh] Remove __EXPERIMENTAL__ #32661

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[eprh] Remove __EXPERIMENTAL__ #32661

wants to merge 2 commits into from
+711 −161

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 18, 2025 •
edited
Loading

__EXPERIMENTAL__ flag doesn't have any use outside of the React repo. Let's remove these flags for now.

Stack created with Sapling. Best reviewed with ReviewStack.

This was referenced Mar 18, 2025
Draft
Draft
@poteto poteto marked this pull request as draft March 18, 2025 17:16
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 18, 2025
@react-sizebot
Copy link

react-sizebot commented Mar 18, 2025 •
edited
Loading

Comparing: 2089052...829e891

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 608.06 kB 608.06 kB = 107.88 kB 107.88 kB
facebook-www/ReactDOM-prod.classic.js = 653.67 kB 653.67 kB = 115.18 kB 115.18 kB
facebook-www/ReactDOM-prod.modern.js = 643.95 kB 643.95 kB = 113.59 kB 113.59 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.76 kB 0.00 kB Deleted 295.92 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.18 kB 0.00 kB Deleted 295.00 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.76 kB 0.00 kB Deleted 295.92 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.18 kB 0.00 kB Deleted 295.00 kB 0.00 kB
oss-experimental/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable-semver/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js Deleted 1,947.59 kB 0.00 kB Deleted 295.89 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js Deleted 1,943.00 kB 0.00 kB Deleted 294.98 kB 0.00 kB
oss-stable/eslint-plugin-react-hooks/index.js Deleted 0.37 kB 0.00 kB Deleted 0.24 kB 0.00 kB

Generated by 🚫 dangerJS against 829e891

poteto added 2 commits March 19, 2025 16:17
@poteto
[eprh] Move to compiler directory
5644e81 
Moves the plugin into the compiler directory.

- Remove eslint-plugin-react-hooks from bundles.js
- Remove eslint-plugin-react-hooks from ReactVersions.js
- Remove jest.config.js
- Remove babel.config-react-compiler.js
- Replace babel.config.js with copy from eslint-plugin-react-compiler
- Add tsup.config.ts to eslint-plugin-react-hooks
- Add eslint-plugin-react-hooks to compiler release scripts
@poteto
[eprh] Remove __EXPERIMENTAL__
829e891 
`__EXPERIMENTAL__` flag doesn't have any use outside of the React repo. Let's remove these flags for now.
@rickhanlonii
Copy link
Member

wait how will we land new lint rule changes when we add new features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poteto @react-sizebot @rickhanlonii @facebook-github-bot