Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:- Added a test for Form reset & case of prevent default. #32689

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Mar 20, 2025

Summary

Added a test for form reset action & when e.preventDefault is done , the form inputs should not be reset to their default values. this test asserts the form reset behaviour. Just good to have i think along with the other tests.

How did you test this change?

ran yarn test packages/react-dom/src/__tests__/ReactDOMEventListener-test.js

Screenshot 2025-03-21 at 12 39 26 AM

Tests are passing.

@Biki-das
Copy link
Contributor Author

Biki-das commented Mar 20, 2025

cc @gaearon @hoxyq @rickhanlonii

@Biki-das Biki-das changed the title Form reset test test:- Added a test for Form reset when using prevent Default. Mar 20, 2025
@react-sizebot
Copy link

react-sizebot commented Mar 20, 2025

Comparing: 7943da1...d23300c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 517.29 kB 517.29 kB = 92.26 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 617.58 kB 617.58 kB = 109.52 kB 109.52 kB
facebook-www/ReactDOM-prod.classic.js = 653.67 kB 653.67 kB = 115.18 kB 115.18 kB
facebook-www/ReactDOM-prod.modern.js = 643.95 kB 643.95 kB = 113.59 kB 113.59 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d23300c

@Biki-das Biki-das changed the title test:- Added a test for Form reset when using prevent Default. test:- Added a test for Form reset & case of prevent default. Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants