[compiler][fix] mutableOnlyIfOperandsAreMutable does not apply when operands are globals #32695
+709
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perands are globals Globals, module locals, and other locally defined functions may mutate their arguments. See test fixtures for details
github-actions
bot
added
the
React Core Team
This was referenced Mar 20, 2025
mofeiZ
commented
Mar 20, 2025
| @@ -101,6 +90,23 @@ const TYPED_GLOBALS: Array<[string, BuiltInType]> = [ | |||
| returnValueKind: ValueKind.Mutable, | |||
| }), | |||
| ], | |||
| [ | |||
There was a problem hiding this comment.
Added this definition for unit test (see newly added repro-array-map-known-mutate-shape.tsx). It was hard finding a global function that (1) has no mutable receiver, (2) only takes one argument, and (3) mutates its argument.
mofeiZ
commented
Mar 20, 2025
| @@ -372,6 +378,86 @@ const TYPED_GLOBALS: Array<[string, BuiltInType]> = [ | |||
| returnValueKind: ValueKind.Primitive, | |||
| }), | |||
| ], | |||
| [ | |||
There was a problem hiding this comment.
Added these drive-by (similar to Boolean) to try to limit scope of deopt.
josephsavona
approved these changes
Mar 21, 2025
mofeiZ
added a commit
that referenced
this pull request
Mar 24, 2025
…handling (#32696) Simplify InferReferenceEffect function signature matching logic for next PRs in stack --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32696). * #32698 * #32697 * __->__ #32696 * #32695
github-actions bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
…handling (#32696) Simplify InferReferenceEffect function signature matching logic for next PRs in stack --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32696). * #32698 * #32697 * __->__ #32696 * #32695 DiffTrain build for [45463ab](45463ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Globals, module locals, and other locally defined functions may mutate their arguments. See test fixtures for details
Stack created with Sapling. Best reviewed with ReviewStack.