Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Multiple Index Files #181

Merged

Conversation

gwbaik9717
Copy link
Contributor

@gwbaik9717 gwbaik9717 commented Mar 19, 2025

Description

This PR allows support for multiple index files.

Also, index files other than index.js are supported such as index.client.js and index.server.js.

To enable these improvements, the @steiger/filesystem package has been upgraded to v3.0.0. As part of this update, the getIndex function has been replaced with the new getIndexes function.

Fixes

Fixes #180

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 7b70464

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@feature-sliced/steiger-plugin Patch
steiger Patch
@steiger/integration-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gwbaik9717 gwbaik9717 changed the title Bump up @steiger/filesystem to 3.0.0 Support for Multiple Index Files Mar 19, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…with-getIndexes
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Sorry it took so long to get a review, I'm a bit less active lately. Everything looks good, but I noticed that the no-layer-public-api rule does not have a test for the added code, could you add that please?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@gwbaik9717 gwbaik9717 requested a review from illright March 24, 2025 21:16
@illright
Copy link
Member

Thank you! Let's get this merged

@illright illright merged commit b8d083c into feature-sliced:master Mar 24, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR problem (Remix)
2 participants