Skip to content

Add solutions for 1020, 1023, 1025, 1029 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

havanagrawal
Copy link
Contributor

@havanagrawal havanagrawal commented Apr 21, 2019

Added solutions for

  1. 1020. Number of Enclaves
  2. 1023. Camelcase Matching
  3. 1025. Divisor Game
  4. 1029. Two City Scheduling

Love your repo, would love to contribute to it regularly!

@havanagrawal havanagrawal changed the title Add solutions for 1020, 1023, 1025 Add solutions for 1020, 1023, 1025, 1029 Apr 21, 2019
@fishercoder1534
Copy link
Owner

Thanks a lot for your contribution!
Could you please separate the 4 problems/solutions into each of its respective commits? i.e. one commit per solution.

Thanks a lot!

@havanagrawal
Copy link
Contributor Author

Yes there are exactly four commits, one for each solution

@fishercoder1534
Copy link
Owner

I mean to open one PR for each commit, instead of having all four commits in one PR, just for easy tracking purpose.
Also, the commit for 1023 doesn't contain the README.md change which resides in the commit of 1025.

A better practice would be to have one commit, in one PR, with one complete solution+test+README.md change, thanks!

@havanagrawal
Copy link
Contributor Author

Ah okay, on it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants