Skip to content

Add solution for 951 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Conversation

havanagrawal
Copy link
Contributor

@fishercoder1534
Copy link
Owner

fishercoder1534 commented Apr 24, 2019

Minor nits, otherwise LGTM!

@havanagrawal
Copy link
Contributor Author

Anything I need to change?

@fishercoder1534
Copy link
Owner

Yes, I've left two minor comments, you cannot see them?
image

@fishercoder1534
Copy link
Owner

That's fine, I'll just merge it and fix the build.

@fishercoder1534 fishercoder1534 merged commit c216053 into fishercoder1534:master Apr 24, 2019
@havanagrawal
Copy link
Contributor Author

Yeah I couldn't see them because the comments were pending, you needed to push them out, it happens when you choose "Start a review" instead of "add a single comment"

@fishercoder1534
Copy link
Owner

Very interesting, thanks for the note!

fishercoder1534 pushed a commit that referenced this pull request Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants