Combine duplicate mentions of jsperf setup/teardown code #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines 199 and 203 both describe `setup` and `teardown` code for jsperf tests. This is duplicate information, and one should be removed. In my opinion, it makes more sense to remove the mention on line 199, as the **Note** on line 201 expands on the first sentence of line 199.
|
The second mention as originally written is only slightly repetitive and is done for the purposes of connecting in the readers' minds that the jsperf setup/teardown settings map to the benchmark.js setup/teardown config. I don't see that there's any need for change here. |
|
Note: I might slightly clean up the second reference's wording in the second edition, but there's no need for change as errata. |
getify
force-pushed
the
master
branch
6 times, most recently
from
5cb284a to
8af48e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lines 199 and 203 both describe
setupandteardowncode for jsperf tests. This is duplicate information, and one should be removed.In my opinion, it makes more sense to remove the mention on line 199, as the Note on line 201 expands on the first sentence of line 199.