Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

None of the notifications show up if loading some repo fails #1567

Closed
1 task done
pahnev opened this issue Oct 3, 2024 · 1 comment · Fixed by #1572
Closed
1 task done

None of the notifications show up if loading some repo fails #1567

pahnev opened this issue Oct 3, 2024 · 1 comment · Fixed by #1572
Labels
bug Something isn't working priority:high Items of high importance. Applicable to all users or use-cases

Comments

@pahnev
Copy link

pahnev commented Oct 3, 2024

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

I had some notification stuck in the system from a deleted repo, which also was showing up in the Github web UI.
When opening Gitify, the UI was always just showing "Oops, something went wrong. Try again later.", even though there were other notifications.

Checking the traffic revealed that it loaded the notifications where one of the notifications was the broken one.

[
  <redacted notifications>,
  {
    "id": "12427009267",
    "unread": true,
    "reason": "mention",
    "updated_at": "2024-09-16T14:20:37Z",
    "last_read_at": null,
    "subject": {
      "title": "Merge pull request #251 from pahnev/master",
      "url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/commits/d492609d1ed5752471bfdab6afbd6283c83b9520",
      "latest_comment_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/commits/d492609d1ed5752471bfdab6afbd6283c83b9520",
      "type": "Commit"
    },
    "repository": {
      "id": 858221833,
      "node_id": "R_kgDOMydtCQ",
      "name": "dear-github-2.0",
      "full_name": "CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0",
      "private": false,
      "owner": {
        "login": "CASIBOM-GIRIS-CASIBOM-GUNCEL",
        "id": 7458478,
        "node_id": "MDQ6VXNlcjc0NTg0Nzg=",
        "avatar_url": "https://avatars.githubusercontent.com/u/7458478?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL",
        "html_url": "https://github.com/CASIBOM-GIRIS-CASIBOM-GUNCEL",
        "followers_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/followers",
        "following_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/following{/other_user}",
        "gists_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/subscriptions",
        "organizations_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/orgs",
        "repos_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/repos",
        "events_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/events{/privacy}",
        "received_events_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/received_events",
        "type": "User",
        "site_admin": false
      },
      "html_url": "https://github.com/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0",
      "description": null,
      "fork": false,
      "url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0",
      "forks_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/forks",
      "keys_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/teams",
      "hooks_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/hooks",
      "issue_events_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/issues/events{/number}",
      "events_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/events",
      "assignees_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/assignees{/user}",
      "branches_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/branches{/branch}",
      "tags_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/tags",
      "blobs_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/languages",
      "stargazers_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/stargazers",
      "contributors_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/contributors",
      "subscribers_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/subscribers",
      "subscription_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/subscription",
      "commits_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/contents/{+path}",
      "compare_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/merges",
      "archive_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/downloads",
      "issues_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/issues{/number}",
      "pulls_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/labels{/name}",
      "releases_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/releases{/id}",
      "deployments_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/deployments"
    },
    "url": "https://api.github.com/notifications/threads/12427009267",
    "subscription_url": "https://api.github.com/notifications/threads/12427009267/subscription"
  },
  {
    "id": "12427009054",
    "unread": true,
    "reason": "mention",
    "updated_at": "2024-09-16T14:20:37Z",
    "last_read_at": null,
    "subject": {
      "title": "Adding @pahnev",
      "url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/commits/c56e03434b3c1a15fa0dffafdd1cb77f95f624e9",
      "latest_comment_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/commits/c56e03434b3c1a15fa0dffafdd1cb77f95f624e9",
      "type": "Commit"
    },
    "repository": {
      "id": 858221833,
      "node_id": "R_kgDOMydtCQ",
      "name": "dear-github-2.0",
      "full_name": "CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0",
      "private": false,
      "owner": {
        "login": "CASIBOM-GIRIS-CASIBOM-GUNCEL",
        "id": 7458478,
        "node_id": "MDQ6VXNlcjc0NTg0Nzg=",
        "avatar_url": "https://avatars.githubusercontent.com/u/7458478?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL",
        "html_url": "https://github.com/CASIBOM-GIRIS-CASIBOM-GUNCEL",
        "followers_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/followers",
        "following_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/following{/other_user}",
        "gists_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/subscriptions",
        "organizations_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/orgs",
        "repos_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/repos",
        "events_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/events{/privacy}",
        "received_events_url": "https://api.github.com/users/CASIBOM-GIRIS-CASIBOM-GUNCEL/received_events",
        "type": "User",
        "site_admin": false
      },
      "html_url": "https://github.com/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0",
      "description": null,
      "fork": false,
      "url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0",
      "forks_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/forks",
      "keys_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/teams",
      "hooks_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/hooks",
      "issue_events_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/issues/events{/number}",
      "events_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/events",
      "assignees_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/assignees{/user}",
      "branches_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/branches{/branch}",
      "tags_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/tags",
      "blobs_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/languages",
      "stargazers_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/stargazers",
      "contributors_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/contributors",
      "subscribers_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/subscribers",
      "subscription_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/subscription",
      "commits_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/contents/{+path}",
      "compare_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/merges",
      "archive_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/downloads",
      "issues_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/issues{/number}",
      "pulls_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/labels{/name}",
      "releases_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/releases{/id}",
      "deployments_url": "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/deployments"
    },
    "url": "https://api.github.com/notifications/threads/12427009054",
    "subscription_url": "https://api.github.com/notifications/threads/12427009054/subscription"
  }
]

And when loading the details for that notification, the API returned 404.

curl -H "Host: api.github.com" -H "sec-ch-ua: \"Not;A=Brand\";v=\"24\", \"Chromium\";v=\"128\"" -H "sec-ch-ua-mobile: ?0" -H "authorization: token <redacted>" -H "user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) gitify/5.14.0 Chrome/128.0.6613.120 Electron/32.1.0 Safari/537.36" -H "content-type: application/json" -H "accept: application/json" -H "cache-control: " -H "sec-ch-ua-platform: \"macOS\"" -H "sec-fetch-site: cross-site" -H "sec-fetch-mode: cors" -H "sec-fetch-dest: empty" -H "accept-language: en-GB" -H "priority: u=1, i" --compressed "https://api.github.com/repos/CASIBOM-GIRIS-CASIBOM-GUNCEL/dear-github-2.0/commits/d492609d1ed5752471bfdab6afbd6283c83b9520"
{
  "message": "Not Found",
  "documentation_url": "https://docs.github.com/rest",
  "status": "404"
}

🪜 Steps To Reproduce

  1. Generate notification from a repo.
  2. Delete the repo
  3. Check notifications in Gitify

Gitify Version

5.14.0

Operating System

macOS

GitHub Account

GitHub Cloud

📸 Screenshots

No response
@pahnev pahnev added the bug Something isn't working label Oct 3, 2024
@setchy setchy added the priority:high Items of high importance. Applicable to all users or use-cases label Oct 3, 2024
@setchy setchy mentioned this issue Oct 5, 2024
Merged
@setchy
Copy link
Member

setchy commented Oct 5, 2024

Thanks for the detailed error report @pahnev - the notification response excerpt was super helpful to reproduce.

Fix raised #1572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:high Items of high importance. Applicable to all users or use-cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: continue if notification enrichment fails gitify-app/gitify
2 participants
@setchy @pahnev