Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross gitify #113

Merged
merged 7 commits into from
Dec 7, 2015
Merged

Cross gitify #113

merged 7 commits into from
Dec 7, 2015

Conversation

mrmlnc
Copy link
Contributor

@mrmlnc mrmlnc commented Nov 5, 2015

Changelog:

  • Update dependencies
  • Add EditorConfig
  • Correct determining of the position
  • Pretty code
  • Support Windows & Linux

Tested:

  • Windows 10 (all taskbar positions: bottom, top, left and right)
  • Linux Mint XFCE (top and bottom)
  • Linux Manjaro XFCE (bottom, top, left and right)
  • Ubuntu 14LTS (requires libappindicator1, but works)

Please test on OS X and let me know if it works.

Not tested:

Auto-update

They say that now works on OS X and Windows with Squirrel but I disabled it for Windows.

If just set version to 0.1.17 and check updates on Windows, then:

ERRORED.
Event: {}. MESSAGE: Can not find Squirrel

Auto-launch

Windows complains on:

process.execPath.match(/.*?\.app/)[0]

I removed [0]. OS X requires it?

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Nov 5, 2015

Ooops, new jest-cli requires Node.js >=4 :(

@manosim
Copy link
Member

manosim commented Nov 5, 2015

That looks awesome @mrmlnc ! Can't wait to give it a go! 🌟

@manosim
Copy link
Member

manosim commented Nov 5, 2015

@mrmlnc It looks like Windows - Auto Update was just released 😋 Would you like to have a look if it's easy to implement autoupdate for Windows too? http://blog.atom.io/2015/11/05/electron-updates-mac-app-store-and-windows-auto-updater.html

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Nov 5, 2015

XO-XO 🐙 🎉

image

Well, I'll think about this tomorrow. At first it seems that there is nothing complicated here :)

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Nov 6, 2015

@ekonstantinidis The server-side setup for Windows Squirrel is also different from OS X. I don't know how to work with that. Wait jenslind/electron-gh-releases#4

@manosim
Copy link
Member

manosim commented Nov 6, 2015

Yes you're right! We can leave Windows - Auto Update for later I guess! 👍

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Nov 6, 2015

Maybe can use a custom solution, such as Electron Superkit. Although it seems to me that better to think about Squirrel.Windows.

@vicentedealencar
Copy link

Hi, right now I am starring at a Can not find Squirrel error message so I found this issue, did you solved this one yet?

The server-side setup for Windows Squirrel is also different from OS X. I don't know how to work with that.

serve the releases folder as static files and it just works

@manosim manosim merged commit 452484f into gitify-app:master Dec 7, 2015
@manosim
Copy link
Member

manosim commented Dec 7, 2015

Hello there! Sorry for the late reply - I've been super busy! So I spent the last couple of days trying to bring the whole project up to date, updating to react 0.14.3, react-router 1.0.1, jest to 0.8.0, electron to 0.35.2 and pretty much all the dependencies.. Also had to fix the completely broken tests because of react 0.14's context etc.

So part of this PR is already merged - but haven't merged the windows & linux support yet. Thought I should let you know since there are some breaking changes in master now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants