Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in field names in the CheckSuite struct #3443

Closed
alexandear opened this issue Jan 20, 2025 · 1 comment · Fixed by #3444
Closed

Typo in field names in the CheckSuite struct #3443

alexandear opened this issue Jan 20, 2025 · 1 comment · Fixed by #3444
Assignees

Comments

@alexandear
Copy link
Contributor

The struct github.CheckSuite contains two fields with typos:

  • Rerequstable -> Rerequestable (because json:"rerequestable")
  • RunsRerequstable -> RunsRerequestable (because json:"runs_rerequestable")

The issue is easy to fix, but this will break backward compatibility. That's why I created the issue and I'm not sure if we should fix it.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 20, 2025

Yes, let's please fix it... because we have other breaking API changes that can all go together into the next major release.
Thank you, @alexandear, for finding and for checking, and I'm guessing for fixing shortly as well! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants