feat!: Add support for network-configurations endpoints for organization #3511
Conversation
…endpoints for organization Implement functionality to list, create, get, update, and delete organization network configurations, as well get network settings resources. References: - GitHub REST API: https://docs.github.com/en/rest/orgs/network-configurations
|
I have discovered that the request only allows “actions” or “none” for the compute service, but the get operations can return “codespaces”. I think I will tackle this tomorrow. https://docs.github.com/en/rest/orgs/network-configurations?apiVersion=2022-11-28#create-a-hosted-compute-network-configuration-for-an-organization & https://docs.github.com/en/rest/orgs/network-configurations?apiVersion=2022-11-28#update-a-hosted-compute-network-configuration-for-an-organization |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3511 +/- ##
==========================================
+ Coverage 91.21% 91.28% +0.06%
==========================================
Files 182 183 +1
Lines 15930 16053 +123
==========================================
+ Hits 14531 14654 +123
Misses 1225 1225
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gmlewis the structs for the enterprise and organization are not different, should I use only one type? |
Yes, please. No need to make a separate struct. Please add a comment that the endpoints support both. |
…r create/update operation and corresponding test cases.
|
@jndz2 - am I correct in saying that this PR will completely resolve #3462? |
@gmlewis second and third are identical and this PR will resolve the issue. |
… enterprise create/update operations
gmlewis
added
the
Breaking API Change
There was a problem hiding this comment.
Thank you, @jndz2!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
gmlewis
changed the title
|
Thank you @jndz2 and @stevehipwell! |
BREAKING CHANGE:
EnterpriseNetwork*structs have been replaced withNetwork*structs.Fixes: #3462.
This pull request introduces support for the hosted compute network configurations for organization in the go-github library, addressing #3462.
Changes Include:
Implementation of API endpoints for managing network-configuration endpoints.
Support for the following operations:
Additional Information:
API Reference: GitHub REST API: Network Configurations.