Users API - return incorrect information

[MytsYurii]

Users API: orgs/%v/members - return us a list of users.
User struct has a field : SiteAdmin which is *bool.

Am I right that this should return true if the user is an enterprise Owner?

if so it do not work as expected.

also other fields such as permissions/role name - are always empty or nil.

even with admin user permissions.

[gmlewis]

According to the official documentation: https://docs.github.com/en/rest/orgs/members?apiVersion=2022-11-28#list-organization-members
it appears that the answer is "yes".

To debug issues like this, we typically use go-httpdebug to have go-github print out the curl equivalent of the command you are issuing to GitHub, and then manually run the curl and see if there are any fields missing.

If both curl and the ListMembers endpoint are missing the fields of interest, then you can contact GitHub Tech Support and ask why they are missing. (One answer that is sometimes returned is that the PAT (Personal Access Token) being used in the call doesn't have the correct roles or the owner of that PAT does not have permission to return the requested information.)

If, however, curl returns the desired fields but this repo's endpoint does NOT, then either the field is missing entirely or we have some other bug or issue that is preventing it from getting through.

Feel free to report back in this issue what your findings are after following the above advice. Thanks.

[MytsYurii]

@gmlewis official user schema does not include roles/ permissions into response, but Go library has it.
I suppose it should be updated: https://docs.github.com/en/rest/orgs/members?apiVersion=2022-11-28#list-organization-members

[gmlewis]

Very frequently in this repo we reuse structs for many endpoints, and I am extremely hesitant to remove fields unless we can conclusively prove that a field is not used anywhere else.

What can easily be done, and please let me know if you would like to do this, is to add a comment to the struct that it is NOT populated by the "following endpoints: ...".

[MytsYurii]

didn't take into a count that it is used in other endpoints where it can be returned.