Make NewClientWithEnvProxy Deprecated

[nothingcompare2u]

The former pr: #2686

As this issue #2898 says NewClientWithEnvProxy is redundant with NewClient(nil).

var DefaultTransport RoundTripper = &Transport{
	Proxy: ProxyFromEnvironment,
	DialContext: defaultTransportDialContext(&net.Dialer{
		Timeout:   30 * time.Second,
		KeepAlive: 30 * time.Second,
	}),
	ForceAttemptHTTP2:     true,
	MaxIdleConns:          100,
	IdleConnTimeout:       90 * time.Second,
	TLSHandshakeTimeout:   10 * time.Second,
	ExpectContinueTimeout: 1 * time.Second,
}

[nothingcompare2u]

@gmlewis Could you have a look?

I am sorry for submitting a premature pr before, and let me remove it.

[gmlewis]

@gmlewis Could you have a look?

I am sorry for submitting a premature pr before, and let me remove it.

No, I will not accept PRs for #2898 until there is discussion in that thread that proves the original issues are resolved.

Specifically, see: #2898 (comment)

[gmlewis]

Additionally, we try not to simply remove things, as we prefer to deprecate them first (also discussed in #2898).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (2b8c7fa) to head (f997fcb).
Report is 198 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3387      +/-   ##
==========================================
- Coverage   97.72%   92.21%   -5.51%     
==========================================
  Files         153      173      +20     
  Lines       13390    14768    +1378     
==========================================
+ Hits        13085    13618     +533     
- Misses        215     1060     +845     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DiegoDev2]

Hi, maybe the issue does not have labels, it should have some that need to be reviewed or something like that, right? @gmlewis