Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hballard/graphql-python-subscriptions
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: hballard/graphql-python-subscriptions
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: executors
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 17 files changed
  • 1 contributor

Commits on Jun 24, 2017

  1. Copy the full SHA
    f4fb7b8 View commit details

Commits on Jun 25, 2017

  1. Copy the full SHA
    f6804de View commit details
  2. Complete initial refactor of concurrency executor

    Set default executor as gevent since it works on both Python 2/3; both
    the manager and transport packages allow user to pass in an executor
    class at instantiation; may modify this user interface once I add
    asyncio as an executor.
    hballard committed Jun 25, 2017
    Copy the full SHA
    a3971d1 View commit details
  3. Copy the full SHA
    c888907 View commit details

Commits on Jun 27, 2017

  1. Complete AsyncioExecutor interface

    Shares essentially same interface as GeventExecutor
    hballard committed Jun 27, 2017
    Copy the full SHA
    e8ebc23 View commit details

Commits on Jun 29, 2017

  1. Copy the full SHA
    d022e66 View commit details

Commits on Jun 30, 2017

  1. Copy the full SHA
    d31deae View commit details

Commits on Jul 1, 2017

  1. Complete GeventExecutor class initial implementation

    Passes all existing tests.  All concurrency and websocket code now uses
    GeventExecutor class, which is injected (vs inherited like previous) by
    user at Pubsub instantiation. I will modify AsyncioExecutor to
    now utilize the same interface as the GeventExecutor.
    hballard committed Jul 1, 2017
    Copy the full SHA
    c4844d6 View commit details
  2. Refactor AsyncExecutor to match GeventExecutor interface

    Also refactored project layout a bit more.
    hballard committed Jul 1, 2017
    Copy the full SHA
    a59d721 View commit details

Commits on Jul 11, 2017

  1. Add asyncio test module; refactor code a bito

    Gevent has one additional test failing after refactor; need to
    troubleshoot it before I release.
    hballard committed Jul 11, 2017
    Copy the full SHA
    8ff97d8 View commit details

Commits on Jul 15, 2017

  1. Make several modifications to executor logic

    Change asyncio "join" method; construct "delayed_backgrd_task" method;
    various other minor changes
    hballard committed Jul 15, 2017
    Copy the full SHA
    9ecbd39 View commit details

Commits on Jul 22, 2017

  1. Copy the full SHA
    3d77246 View commit details
  2. Refactor websocket obj to be initialized in exeutor

    This is versus the previous implementation of using static methods on
    the executor and passing it explicitly to each one
    hballard committed Jul 22, 2017
    Copy the full SHA
    3617e87 View commit details

Commits on Jul 23, 2017

  1. Copy the full SHA
    f667f9d View commit details

Commits on Jul 26, 2017

  1. Sub manager & pubsub tests now pass for asyncio

    Continue to work on getting transport server tests to pass for
    asyncio.  There are two gevent transport server tests that need to
    be fixed.  Also refactored out fakeredis, preferring to start
    redis-server instance in test setup code
    hballard committed Jul 26, 2017
    Copy the full SHA
    1529c45 View commit details

Commits on Jul 29, 2017

  1. Server tests all pass for gevent; working on asyncio

    Several asyncio server class tests are the only tests still failing after
    this major refactor. Focus on getting these to pass.
    hballard committed Jul 29, 2017
    Copy the full SHA
    dfd5826 View commit details

Commits on Aug 3, 2017

  1. Fix Sanic server to handle websocket subprotocols

    7 tests still fail
    hballard committed Aug 3, 2017
    Copy the full SHA
    981dbb7 View commit details

Commits on Aug 15, 2017

  1. Copy the full SHA
    c139149 View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff master...executors