Use try-with-resources #999
Merged
+14
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exceptionfactory
suggested changes
Mar 19, 2025
There was a problem hiding this comment.
Thanks for proposing the improvements @simon04.
The GitHub build workflow is failing due to an incompatibility with Java 8 as highlighted. Adjusting the approach should resolve the compatibility problem.
| @@ -318,10 +318,8 @@ public void writeShort(int v) | |||
| public void writeUTF(String str) | |||
| throws IOException { | |||
| final DataOutputStream dos = new DataOutputStream(rf.new RemoteFileOutputStream(fp)); | |||
| try { | |||
| try (dos) { | |||
There was a problem hiding this comment.
This changes is not supported on Java 8 according to the automated tests:
/home/runner/work/sshj/sshj/src/main/java/net/schmizz/sshj/sftp/RandomAccessRemoteFile.java:321: error: variables in try-with-resources are not supported in -source 8
try (dos) {
^
(use -source 9 or higher to enable variables in try-with-resources)
It looks like fp could be updated inside the try block.
simon04
force-pushed
the
try-with-resources
branch
from
fa3f848 to
be9c5ce
Compare
|
Thanks for the PRs, keep them coming! 🎉 |
hierynomus
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.