Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in modules slide? #487

Closed
hageboeck opened this issue Aug 30, 2023 · 1 comment · Fixed by #491
Closed

Mistake in modules slide? #487

hageboeck opened this issue Aug 30, 2023 · 1 comment · Fixed by #491
Assignees

Comments

@hageboeck
Copy link
Contributor

hageboeck commented Aug 30, 2023

In the following slide, import export module base is probably incorrect.
(I don't find any "import export" on https://en.cppreference.com/w/cpp/language/modules.)

image

Presumably, the correct syntax is import export base, but needs to be checked.

@bernhardmgruber
Copy link
Contributor

Yeah, this looks wrong. It should probably be export import base;.

Generally, this example looks very complicated. It may benefit from a little overhaul. I will have a look in a few days.

bernhardmgruber added a commit to bernhardmgruber/cpluspluscourse that referenced this issue Sep 12, 2023
bernhardmgruber added a commit to bernhardmgruber/cpluspluscourse that referenced this issue Sep 12, 2023
Fixes: hsf-training#487

Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
bernhardmgruber added a commit that referenced this issue Sep 12, 2023
Fixes: #487

Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants