Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Fix auth type definitions and add more #8323

Merged
merged 8 commits into from
Mar 23, 2025
Merged

Conversation

MichaelVerdon
Copy link
Collaborator

@MichaelVerdon MichaelVerdon commented Feb 11, 2025

Description

Added and edited type definitions to match Firebase JS-SDK with tests for definitions. Furthermore, this should fix this issue

Closes #8368
Closes #8311

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 23, 2025 4:45pm

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@MichaelVerdon MichaelVerdon changed the title Fix auth types fix(auth): Fix auth type definitions and add more Feb 11, 2025
@MichaelVerdon MichaelVerdon marked this pull request as ready for review February 11, 2025 16:41
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I reviewed current status, fixed conflicts, and handled the tiny remaining feedback from PR review of return type in a typedoc. I'd like to merge this as it fixes a lot of user-noticed problems moving to modular API

@mikehardy mikehardy dismissed russellwheatley’s stale review March 23, 2025 16:43

review comments all handled now

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 23, 2025
@mikehardy mikehardy merged commit 3dc8119 into main Mar 23, 2025
17 of 19 checks passed
@mikehardy mikehardy deleted the fix-auth-types branch March 23, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workflow: Pending Merge Waiting on CI or similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Auth providers are missing from top-level modular types
5 participants