-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): Fix auth type definitions and add more #8323
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bdfbfa6
to
249b92b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I reviewed current status, fixed conflicts, and handled the tiny remaining feedback from PR review of return type in a typedoc. I'd like to merge this as it fixes a lot of user-noticed problems moving to modular API
review comments all handled now
Description
Added and edited type definitions to match Firebase JS-SDK with tests for definitions. Furthermore, this should fix this issue
Closes #8368
Closes #8311
Related issues
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter