-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(auth): update examples to use modular API #8327
base: main
Are you sure you want to change the base?
docs(auth): update examples to use modular API #8327
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8b0286b
to
db17815
Compare
db17815
to
fa7de9b
Compare
fa7de9b
to
f2782c2
Compare
bae7527
to
7fb2af3
Compare
7fb2af3
to
293999c
Compare
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Hi @mikehardy, IMHO the docs would still benefit from this PR. Thanks in advance for taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm 🤔 These aren't quite right though...
- currentUser is accessed as
auth.currentUser
on the return value ofgetAuth()
- all methods should be patterned as
methodName(getAuth(), <params>)
so there should never be an auth
import, and there shouldn't be any getAuth().methodName()
The modular
sections of the e2e test suites are the working examples at the moment
Description
This PR updates the authentication docs to use the modular API.
I just finished migrating an app to the modular API and put my insights into this PR hoping the next person can benefit from it.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I'll wait for the Vercel preview and then read the docs again. I already cross-checked the edits I made with my own code after the migration.
🔥
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter