Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add close button text property #30282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

niconaso
Copy link

@niconaso niconaso commented Mar 20, 2025

Issue number: internal


What is the new behavior?

  • Introduces a new property to Modal interface to customize the close button text.
  • Adds e2e tests to for the new prop.

Does this introduce a breaking change?

  • Yes
  • No

Add a new property to customize the close button in the select when the interface is Modal.
@niconaso niconaso requested a review from a team as a code owner March 20, 2025 15:24
@niconaso niconaso requested a review from gnbm March 20, 2025 15:24
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 3:26pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Mar 20, 2025
@niconaso niconaso changed the title feat(select): allow to pass custom close button text feat(select): add close button text property Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant