Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar dropdown open position #71

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

pristavu
Copy link
Contributor

@pristavu pristavu commented Mar 2, 2025

This update aligns the vue-starter-kit with react-starter-kit regarding the sidebar dropdown

This update aligns the vue-starter-kit with react-starter-kit regarding the sidebar dropdown
@pristavu pristavu changed the title fix: sidebar open position fix: sidebar dropdown open position Mar 2, 2025
@tnylea
Copy link
Contributor

tnylea commented Mar 3, 2025

Can you please elaborate more on what this PR does. Additionally if there are UI changes, can you please provide a before and after.

Thank you 🙏

@tnylea tnylea added the Awaiting User Response Waiting for developers response label Mar 3, 2025
@pristavu
Copy link
Contributor Author

pristavu commented Mar 4, 2025

It fixes the DropdownMenu position when sidebar is collapsed:

before after

Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 👏

Thank you!

@tnylea tnylea added Approved Approved for merge and removed Awaiting User Response Waiting for developers response labels Mar 10, 2025
@taylorotwell taylorotwell merged commit 6fa726e into laravel:main Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants