Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile avatar functionality to Laravel Vue starter kit #79

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bennajah
Copy link

@bennajah bennajah commented Mar 7, 2025

feat: add profile avatar functionality to Laravel Vue starter kit

  • Added profile_photo_path column to users migration
  • Appended avatar to User model for profile photo handling
  • Implemented getAvatarAttribute() accessor to fetch user's profile photo URL
  • Enabled profile photo upload and deletion functionality

image

@tnylea
Copy link
Contributor

tnylea commented Mar 10, 2025

Excellent. I'll be testing these out this week.

I would also like to get this added into the Livewire starter kits too. Would you be able to add the profile photo to the Starter kit as well. If you are not as comfortable with that stack, I'm sure myself or someone else will be able to help out with that.

Thanks!

@tnylea tnylea added the Additional Testing in Progress Needs more testing or waiting until we can add this feature to all starter kits label Mar 10, 2025
@bennajah
Copy link
Author

Yes I will add livewire PR

@bennajah
Copy link
Author

@tnylea

Livewire PR Submited laravel/livewire-starter-kit#60

@tnylea
Copy link
Contributor

tnylea commented Mar 19, 2025

This is looking really good!

Could you update the getAvatarAttribute accessor to use the latest way of defining Accessors, similar to the suggestion in the React PR.

Also, I noticed that this is working correctly on the React version but not the same in the Vue version. When I click on the Save button, it does not update the avatar in the bottom left. When I remove the photo, it does not remove it from the Photo placeholder or the user menu on the bottom right. Screencast attached 👇

photo-issues.mp4

If you could update those, I'll approve this, and then we can merge it in. I really appreciate it!

@tnylea tnylea added Awaiting User Response Waiting for developers response and removed Additional Testing in Progress Needs more testing or waiting until we can add this feature to all starter kits labels Mar 19, 2025
@bennajah
Copy link
Author

This is looking really good!

Could you update the getAvatarAttribute accessor to use the latest way of defining Accessors, similar to the suggestion in the React PR.

Also, I noticed that this is working correctly on the React version but not the same in the Vue version. When I click on the Save button, it does not update the avatar in the bottom left. When I remove the photo, it does not remove it from the Photo placeholder or the user menu on the bottom right. Screencast attached 👇

photo-issues.mp4
If you could update those, I'll approve this, and then we can merge it in. I really appreciate it!

fixed in last commit

@majweb
Copy link

majweb commented Mar 24, 2025

Will the crop functionality work in the starter kit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting User Response Waiting for developers response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants