Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationError: themeConfig.navbar.links has been renamed as themeConfig.navbar.items error #38

Closed
manjillama opened this issue Aug 1, 2020 · 2 comments

Comments

@manjillama
Copy link
Contributor

Hi! I tried to run the project but it seems a validation system was added recently to Docusaurus as an attempt to avoid user configuration errors.

Expected Behaviour

Project to sucessfully run without failure.

Actual Behaviour

Project fails to run with validation error.

ValidationError: themeConfig.navbar.links has been renamed as themeConfig.navbar.items
error 

I've applied a minor patch and sent a pull request fixing the issue.

Step to reproduce

Clone the project and run npm install and then yarn start

Error Screenshot

Screen Shot 2020-08-01 at 8 08 58 PM

P.S. I'm really sorry if you guys don't accept PR from outside the company. I saw an issue and decided to address it.

@mesaugat
Copy link
Member

mesaugat commented Aug 2, 2020

Hello @manjillama,

I believe you ran into the issue because you did npm install and it installed the latest docusaurus package.

We primarily use yarn and have yarn.lock included in the repository. Can you try using yarn to install the dependencies? I did this on my end and it's working fine.

Let me know if it doesn't work for you. Also, we do accept PRs from outside the company. 🙂

@manjillama
Copy link
Contributor Author

@mesaugat Right! That fixed it! Thanks for the clarification. I'll go ahead and close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants