Use strict variance checks for strict subtype checks unconditionally #48123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this comment in #41977 relevant at all?
|
|
For the subtype relation, that's probably true, however for the |
|
(You can see the playground link in the OP for an example of the very problematic order dependence issue) |
|
@typescript-bot pack this |
|
Heya @weswigham, I've started to run the extended test suite on this PR at 949daee. You can monitor the build here. |
|
Heya @weswigham, I've started to run the tarball bundle task on this PR at 949daee. You can monitor the build here. |
|
Heya @weswigham, I've started to run the perf test suite on this PR at 949daee. You can monitor the build here. Update: The results are in! |
|
Heya @weswigham, I've started to run the diff-based community code test suite on this PR at 949daee. You can monitor the build here. Update: The results are in! |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 949daee. You can monitor the build here. |
|
@weswigham Here they are:Comparison Report - main..refs/pull/48123/merge [bcryptjs]1 of 1 projects failed to build with the old tsc /mnt/ts_downloads/bcryptjs/tsconfig.json
|
| @@ -36,8 +36,8 @@ var cs = [a, b, c]; // { x: number; y?: number };[] | |||
| >c : { x: number; a?: number; } | |||
|
|
|||
| var ds = [(x: Object) => 1, (x: string) => 2]; // { (x:Object) => number }[] | |||
| >ds : ((x: Object) => number)[] | |||
| >[(x: Object) => 1, (x: string) => 2] : ((x: Object) => number)[] | |||
| >ds : ((x: string) => number)[] | |||
There was a problem hiding this comment.
This is a pretty big correctness improvement, so we should document it as a breaking change
|
@weswigham Here they are:Comparison Report - main..48123
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Man, xstate is fine but compiler-unions really hates this; but... Why? None of the unions in compiler-unions even have methods... Hm. Probably warrants investigation. |
sandersn
added
the
For Milestone Bug
|
@typescript-bot perf test this |
|
Heya @weswigham, I've started to run the perf test suite on this PR at afb0126. You can monitor the build here. Update: The results are in! |
|
@weswigham Here they are:Comparison Report - main..48123
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@weswigham did this pan out? Did you figure out why compiler-unions slowed down? It's old enough that I'd like to close it if it didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reviewing some older PRs in my review queue and realized I had some extra insight into one in particular since I'd last commented on it.
This is an improvement to #41995 that, rather than making anything dependent on the
strictFunctionTypesflag, instead changes the strict subtype relation to always use strict function argument variance, which both fixes #41977, and should prevent order-dependence issues like those described in #46814 (but with methods instead of readonly props, like so) as well.