Contextually type the right operand of logical or & nullish coalescing using non-nullable left type

[Andarist]

closes #54551

[gabritto]

@typescript-bot test this
@typescript-bot run DT
@typescript-bot user test this
@typescript-bot test top100
@typescript-bot perf test this

[typescript-bot]

Heya @gabritto, I've started to run the parallelized Definitely Typed test suite on this PR at 8572cde. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @gabritto, I've started to run the diff-based top-repos suite on this PR at 8572cde. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @gabritto, I've started to run the diff-based user code test suite on this PR at 8572cde. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @gabritto, I've started to run the extended test suite on this PR at 8572cde. You can monitor the build here.

[typescript-bot]

Heya @gabritto, I've started to run the perf test suite on this PR at 8572cde. You can monitor the build here.

[typescript-bot]

@gabritto Here are the results of running the user test suite comparing main and refs/pull/54553/merge:

There were infrastructure failures potentially unrelated to your change:

• 1 instance of "Unknown failure"
• 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

• [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-54553/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
• [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
  • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

[typescript-bot]

@gabritto Here are the results of running the top-repos suite comparing main and refs/pull/54553/merge:

Everything looks good!

[typescript-bot]

Hey @gabritto, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.