Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mrdoob/three.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dev
Choose a base ref
...
head repository: mrdoob/three.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: gltf-export-compressed-data
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 5 files changed
  • 2 contributors

Commits on May 23, 2023

  1. allow exporting compressed meshes and textures (e.g. draco + ktx2) 

    added coffemat.etc1s.glb and etc1s+draco, etc1s+meshopt to test compressed formats

only use one temp render context, clean up renderer after writing file, make metalnessMap and roughnessMap readable

refactor: move to TextureUtils class and use that in GLTFExporter, respect sRGB vs. Linear, cache some generated objects

cleanup

simplify modifiedMap access

fix formatting for TextureUtils

dispose of temporary renderer

remove duplicate switch entries
    @hybridherbst
    hybridherbst committed May 23, 2023
    Copy the full SHA
    706e9cf View commit details

  2. addressing PR feedback and updating to colorSpace

    @hybridherbst
    hybridherbst committed May 23, 2023
    Copy the full SHA
    3f1307e View commit details

  3. remove meshopt references/test file for now

    @hybridherbst
    hybridherbst committed May 23, 2023
    Copy the full SHA
    d67dda6 View commit details

  4. rm old import

    @hybridherbst
    hybridherbst committed May 23, 2023
    Copy the full SHA
    4e14bb7 View commit details

Commits on May 24, 2023

  1. PR feedback

    @hybridherbst
    hybridherbst committed May 24, 2023
    Copy the full SHA
    c31806c View commit details

  2. GLTFExporter, TextureUtils: Minor fixes.

    @donmccurdy
    donmccurdy committed May 24, 2023
    Copy the full SHA
    4e87041 View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff dev...gltf-export-compressed-data