Docs: fix typos #30776
Merged
Docs: fix typos #30776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Mar 21, 2025
build/three.cjs
Outdated
| @@ -25576,7 +25576,7 @@ class InstancedMesh extends Mesh { | |||
| * {@link InstancedMesh#instanceMatrix} to `true` after updating all the colors. | |||
| * | |||
| * @param {number} index - The instance index. | |||
| * @param {Matrix4} matrix - The the local transformation. | |||
| * @param {Matrix4} matrix - The local transformation. | |||
There was a problem hiding this comment.
Please remove the build files from the PR.
Mugen87
reviewed
Mar 21, 2025
| @@ -3410,7 +3410,7 @@ | |||
| } | |||
|
|
|||
| // Compute the lines that are visible in a given viewport (defaults | |||
| // the the current scroll position). viewport may contain top, | |||
| // the current scroll position). viewport may contain top, | |||
There was a problem hiding this comment.
Please remove all modifications to lib files.
|
@Mugen87 thanks for the review! reverted the changes on those files |
Mugen87
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: fix typos