Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilization of node:sqlite module #57445

Open
everett1992 opened this issue Mar 13, 2025 · 5 comments
Open

stabilization of node:sqlite module #57445

everett1992 opened this issue Mar 13, 2025 · 5 comments
Labels
feature request Issues that request new features to be added to Node.js.

Comments

@everett1992
Copy link
Contributor

What is the problem this feature will solve?

I couldn't find any issues tracking the stabalization of the node:sqlite module. Built in sqlite support will remove the need for native modules which complicate build and distribution.

What is the feature you are proposing to solve the problem?

Eventually stabilizing test sqlite

What alternatives have you considered?

No response

@everett1992 everett1992 added the feature request Issues that request new features to be added to Node.js. label Mar 13, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Mar 13, 2025
@cjihrig
Copy link
Contributor

cjihrig commented Mar 13, 2025

node:sqlite is already unflagged. I would be supportive of dropping the experimental warning as well.

As far as officially stabilizing the module goes, I think there is still some work to do. I think targeting Node v25 in October could be a realistic goal, but there aren't a lot of people working on the effort. Another hurdle is a lack of reviews from collaborators - things move slowly when it takes roughly a week to get changes merged.

@everett1992
Copy link
Contributor Author

Is there a rough list of what needs done before it can be marked stable?
I'd be happy to review or contribute.

If it's not stable by v24 could it be backported to 24 (and ideally older versions). One of the reasons I want this stabilized soon is so it can be used by libraries / apps with lower minimum supported node versions.

@jasnell
Copy link
Member

jasnell commented Mar 13, 2025

Another hurdle is a lack of reviews from collaborators - things move slowly when it takes roughly a week to get changes merged...

These are not always readily visible. If there are specific PRs please tag me and I'll be happy to review.

@marco-ippolito marco-ippolito changed the title stabalization of node:sqlite module stabilization of node:sqlite module Mar 14, 2025
@cjihrig
Copy link
Contributor

cjihrig commented Mar 14, 2025

Is there a rough list of what needs done before it can be marked stable?

Not exactly. There are currently some open issues and PRs. Some (not all) of those need to be resolved. I know that @billywhizz had mentioned some potential performance optimizations as well that I think would be good to explore.

If it's not stable by v24 could it be backported to 24

I don't see it making the v24.0.0 cutoff, but it could likely be backported.

@billywhizz
Copy link
Contributor

i can take a look at any work that is outstanding over next few days and can hopefully help with any effort to stabilize this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js.
Projects
Status: Awaiting Triage
Development

No branches or pull requests

4 participants