sqlite: refactor prepared statement iterator #57569
Open
+198
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the StatementSync iterator implementation in two primary ways: - The iterator internal state is no longer exposed to JavaScript. - The iterator prevents the prepared statement from being GC'ed. Fixes: nodejs#57493
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
reviewed
Mar 20, 2025
| THROW_AND_RETURN_ON_BAD_STATE( | ||
| env, iter->stmt_->IsFinalized(), "statement has been finalized"); | ||
| Isolate* isolate = env->isolate(); | ||
| LocalVector<Name> keys(isolate, {env->done_string(), env->value_string()}); |
There was a problem hiding this comment.
Nit... LocalVector here might be overkill when a simple array would do. Non-blocking tho.
jasnell
approved these changes
Mar 20, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57569 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01%
==========================================
Files 630 630
Lines 185013 184989 -24
Branches 36241 36233 -8
==========================================
+ Hits 166966 166971 +5
+ Misses 10998 10973 -25
+ Partials 7049 7045 -4
🚀 New features to boost your workflow:
|
geeksilva97
approved these changes
Mar 20, 2025
|
🙏 This implementation is better than my original one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the StatementSync iterator implementation in two primary ways:
Fixes: #57493