src: ensure primordials are initialized exactly once

[legendecas]

Right now InitializePrimordials is invoked twice on a context created via node::NewContext:

1. InitializeMainContextForSnapshot invokes InitializePrimordials.
2. InitializePrimordials invokes GetPerContextExports unconditionally.
   1. GetPerContextExports invokes InitializePrimordials when node:per_context_binding_exports private was not set.
      1. InitializePrimordials invokes GetPerContextExports and initialize primordials for the first time.
   2. Initialize primordials for the second time.

GetPerContextExports will be invoked during node_mksnapshot by initializing the principal realm so it is safe to remove invocation of InitializePrimordials in InitializeMainContextForSnapshot.

This patch ensures that InitializePrimordials is only invoked in GetPerContextExports and checks that primordials on the private per-context exports object are not initialized before.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65803/

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (38390e5) to head (187fbdb).
Report is 30 commits behind head on main.

Files with missing lines	Patch %	Lines
src/api/environment.cc	25.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57519      +/-   ##
==========================================
- Coverage   90.22%   90.20%   -0.02%     
==========================================
  Files         629      629              
  Lines      184845   184847       +2     
  Branches    36205    36209       +4     
==========================================
- Hits       166784   166749      -35     
- Misses      11016    11055      +39     
+ Partials     7045     7043       -2     

Files with missing lines	Coverage Δ
src/api/environment.cc	76.00% <25.00%> (+0.28%)	⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[atlowChemi]

Is there anyway to benchmark this?
Can we add a test that InitializePrimordials is called only once?

[legendecas]

This CHECK https://github.com/nodejs/node/pull/57519/files#diff-5f2fc380364ef43210af4a28c08f9a0c7ec5f85e3ec1f5c1df5e0204eb9dc721R777 ensures that primordials are initialized only once for a given context.

This does not run at runtime. Primordials are initialized at node_mksnapshot and snapshotted in the startup snapshot. I don't think it is necessary to run benchmark for build time as it is trivially small enough to the total build duration.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65814/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65816/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65833/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65840/

[legendecas]

@nodejs/cpp-reviewers would you mind taking a look at this? Thank you!

[nodejs-github-bot]

Landed in 8b2098f