Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] deps: update undici to v5.29.0 #57557

Open
wants to merge 1 commit into
base: v18.x-staging
Choose a base branch
from
Open

[v18.x] deps: update undici to v5.29.0 #57557

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

This updates Undici to v5.29.0 in Node v18.

@mcollina
deps: update undici to v5.29.0
d3d41ef 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
Copy link
Member Author

cc @nodejs/releasers

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Mar 20, 2025
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65848/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65851/

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau
Copy link
Member

I'd like to fast track this so that I can include it in the Node.js 18 release that I'm preparing for next week.

I don't think the coverage failures are related to this change -- I've opened #57565 to see if backporting a change fixes that.

@richardlau richardlau mentioned this pull request Mar 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau

@RafaelGSS RafaelGSS

@marco-ippolito marco-ippolito

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcollina @nodejs-github-bot @richardlau @RafaelGSS @marco-ippolito