Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: allow the $schema property in node.config.json #57560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remcohaszing
Copy link

The documentation states people can use the $schema property, but the JSON schema forbids this. This change allows it.

The documentation states people can use the `$schema` property, but the
JSON schema forbids this. This change allows it.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 20, 2025
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks!

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (5a7b7d2) to head (6388137).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57560      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      185013   185017       +4     
  Branches    36241    36240       -1     
==========================================
+ Hits       166966   166991      +25     
+ Misses      10998    10993       -5     
+ Partials     7049     7033      -16     
Files with missing lines Coverage Δ
lib/internal/options.js 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 20, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@remcohaszing
Copy link
Author

I’m confused by the unsuccessful checks. Is this something I need to fix or are those checks just unstable?

For example I ended up at https://ci.nodejs.org/job/node-test-commit-linux-containered/49686/nodes=ubuntu2204_sharedlibs_openssl32_x64/testReport/(root)/pummel/test_buffer_large_size/

---
duration_ms: 720105.64
exitcode: -15
severity: fail
stack: |-
  timeout
  (node:3777203) [DEP0030] DeprecationWarning: SlowBuffer() is deprecated. Please use Buffer.allocUnsafeSlow()
  (Use `node --trace-deprecation ...` to show where the warning was created)
...

@marco-ippolito
Copy link
Member

just flaky test 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.