-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: allow the $schema property in node.config.json #57560
base: main
Are you sure you want to change the base?
Conversation
The documentation states people can use the `$schema` property, but the JSON schema forbids this. This change allows it.
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57560 +/- ##
==========================================
+ Coverage 90.24% 90.25% +0.01%
==========================================
Files 630 630
Lines 185013 185017 +4
Branches 36241 36240 -1
==========================================
+ Hits 166966 166991 +25
+ Misses 10998 10993 -5
+ Partials 7049 7033 -16
🚀 New features to boost your workflow:
|
I’m confused by the unsuccessful checks. Is this something I need to fix or are those checks just unstable? For example I ended up at https://ci.nodejs.org/job/node-test-commit-linux-containered/49686/nodes=ubuntu2204_sharedlibs_openssl32_x64/testReport/(root)/pummel/test_buffer_large_size/
|
just flaky test 😄 |
The documentation states people can use the
$schema
property, but the JSON schema forbids this. This change allows it.