Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update sccache to support GH cache changes #57573

Merged
merged 1 commit into from
Mar 23, 2025
Merged

tools: update sccache to support GH cache changes #57573

merged 1 commit into from
Mar 23, 2025
+12 −12

Conversation

targos
Copy link
Member

@targos targos commented Mar 21, 2025

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 21, 2025
@targos targos added lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x labels Mar 21, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 21, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (afe3909) to head (a8e4c1e).
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57573      +/-   ##
==========================================
- Coverage   90.24%   89.71%   -0.54%     
==========================================
  Files         630      630              
  Lines      185013   185013              
  Branches    36249    35930     -319     
==========================================
- Hits       166969   165978     -991     
- Misses      10996    11945     +949     
- Partials     7048     7090      +42

see 94 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 21, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
Copy link
Member

jasnell commented Mar 21, 2025

Just a reminder... can't use commit-queue and fast-track together as the commit queue does not handle fast tracked PRs correctly currently.

@targos
Copy link
Member Author

targos commented Mar 21, 2025

You can use them. You "just" need to make sure the fast-track request is approved before adding commit-queue

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 21, 2025
@aduh95
Copy link
Contributor

aduh95 commented Mar 21, 2025

Let's not fast-track unless we have a good reason to do so

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit f960ee4 into nodejs:main Mar 23, 2025
52 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f960ee4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@anonrig anonrig

@aduh95 aduh95

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @jasnell @aduh95 @lpinca @anonrig