-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: expose v8 fast-calls header to native addons #57574
base: main
Are you sure you want to change the base?
Conversation
cc @nodejs/tsc @nodejs/v8 |
It's not stable. I had to make substantial changes to our internal use of the API in #57114 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking due to #57574 (comment)
I think that can be said about many APIs we use from V8 for every V8 upgrade? Even cc @gahaas who's been doing some deprecation of the fast call API...should it be considered stable enough to allow Node.js addons to use the fast call APIs? |
Chances are that the fast call API will still change a bit this year. |
+1 to holding off. This is still a bit too premature. |
We haven't done that recently because there are too many build issues and V8 versions are not bumped regularly. I hope that we'll be able to do major upgrades again in the future. |
Fixes #52923
This wasn't exposed initially because the V8 team objected to it as it wasn't stable enough.
If everything is stable now, it should be fine to do so now?