Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: expose v8 fast-calls header to native addons #57574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aditi-1400
Copy link
Contributor

Fixes #52923

This wasn't exposed initially because the V8 team objected to it as it wasn't stable enough.
If everything is stable now, it should be fine to do so now?

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Mar 21, 2025
@anonrig anonrig requested a review from jasnell March 21, 2025 15:36
@anonrig
Copy link
Member

anonrig commented Mar 21, 2025

cc @nodejs/tsc @nodejs/v8

@targos
Copy link
Member

targos commented Mar 21, 2025

It's not stable. I had to make substantial changes to our internal use of the API in #57114

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking due to #57574 (comment)

@joyeecheung
Copy link
Member

joyeecheung commented Mar 21, 2025

I had to make substantial changes to our internal use of the API

I think that can be said about many APIs we use from V8 for every V8 upgrade? Even String::Value, which we've been using for I-dont-how-long, were recently deprecated, but I wouldn't call that API unstable. I think it's expected that even very stable APIs can get breaking change in a major V8 upgrade. But since we don't do major V8 upgrade within a major release anyways, that's not really an issue, and having to fix things up for new major release of Node.js is also expected for addons (especially if they use raw V8 APIs).

cc @gahaas who's been doing some deprecation of the fast call API...should it be considered stable enough to allow Node.js addons to use the fast call APIs?

@gahaas
Copy link
Contributor

gahaas commented Mar 21, 2025

Chances are that the fast call API will still change a bit this year.

@jasnell
Copy link
Member

jasnell commented Mar 21, 2025

+1 to holding off. This is still a bit too premature.

@targos
Copy link
Member

targos commented Mar 21, 2025

we don't do major V8 upgrade within a major release anyways

We haven't done that recently because there are too many build issues and V8 versions are not bumped regularly. I hope that we'll be able to do major upgrades again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline for V8 fast-calls header exposed for native addons?
7 participants