src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #57578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
reviewed
Mar 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57578 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.02%
==========================================
Files 629 630 +1
Lines 184939 185054 +115
Branches 36232 36249 +17
==========================================
+ Hits 166885 166961 +76
- Misses 11011 11036 +25
- Partials 7043 7057 +14
🚀 New features to boost your workflow:
|
According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`.
Aditi-1400
force-pushed
the
replace-vector
branch
from
9384897 to
c8f2584
Compare
legendecas
approved these changes
Mar 21, 2025
anonrig
approved these changes
Mar 22, 2025
RaisinTen
approved these changes
Mar 22, 2025
jasnell
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to V8's public API documentation, local handles (i.e., objects of type v8::Local) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of
v8::Local, specifically thestd::vector<v8::Local<v8::String>>with recently introducedv8::LocalVector<T>.This is first of the series of commits to replace all
std::vector<v8::Local<T>>to usev8::LocalVector<T>.